verilog code correction???

[sotomie]

can anyone please tell me if there is any logical error is this always block,its for fibonacci series ,i'm getting my results right but i was just curious if i've done something which isn't correct like using two 'if's?

---

Code Verilog - [expand]
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
always@(posedge clock)
  begin
      if(n==0)
      current=1;
      else
      begin
      temp=current;
      current=current+previous;
      previous=temp;
      end
      if(current<previous)
      begin
            previous=0;
            n=0;
            current=1;
      end
    n=n+1;
   end   
endmodule

---

 

[FvM]

No logical error, but bad style. Synchronous always blocks should use non-blocking statements for variable assignments.

 

[sotomie]

always@(posedge clock)
  begin
      if(n==0)
      current<=1;
      else
      begin
      temp=current;
      current=current+previous;
      previous=temp;
      end
      if(current<previous)
      begin
            previous<=0;
            n<=0;
            current<=1;
      end
    n<=n+1;
   end   
endmodule

better?

 

[FvM]

No, now you have mixed blocking and non-blocking statements for the same variables, which isn't allowed.

 

[sotomie]

can you modify it ? I'm new to verilog.And if i am changing all the blocking assignments to non-blocking results are not right because of this part i think

temp=current;
      current=current+previous;
      previous=temp;

.Thankyou

 

[FvM]

Yes, the code must be differently arranged when using non-blocking statements.