[SOLVED] simple microcontroller ckt problem

[gagandiep]

im new with electronics and this is my first experiment:
im trying to make this simple circuit with an 89s51. the led must go on as i push the button and off as i leave it.

the problem is that it does not work......



someone please tell me if there is anything wrong with this circuit or this program made in kiel:

$mod51org 00h
setb p0.5
clr p3.5


check:
jnb p0.5, light
sjmp check


light:
setb p3.5
jnb p0.5,$
end

please suggest what else i could be doing wrong if the above are correct.

 

[Genovator]

Do not use port 0 for button. Change it to port 2 and see if it works.

org 00h
setb p2.5
clr p3.5


check:
jnb p2.5, light
sjmp check


light:
setb p3.5
jnb p2.5,$
ret
end

You can use pull up resistor technique to use port 0.

Hopes this helps
Genovator