push button with pic16f887

[charu2539211]

hi

i am using a push button connect to the pic16f887. this is my code in assembly language

i have intialised portd0 as input port and portb as output port.

BANKSEL PORTD
BTFSS PORTD,0
GOTO LEDSEL

;;; delay????;;;
BTFSC PORTD,0
GOTO LEDSEL
GOTO DEC1


LEDSEL
...

DEC1
....

so when i press the push button it should go to DEC1, else it should go to LEDSEL
is my program right???
and do i need to add a delay in between?? if so how much???

 

[ausrasul]

Your code is not compelete, from what I see, it will run only once and doesn't loop.
Depends on your application, use an interrupt and connect the button to the interrupt pin, or use a loop (resource hogger) if you're connecting it to an IO pin.
Otherwise your code is ok.