clear bit function is not working in C18 compiler

[Arrowspace]

#define set_bit(x,y) (x=x|(1<<y))
#define clr_bit(x,y) (x=x|(0<<y))

I am trying to set single bit and clearing it, my set function is working, but clear function is not working.

 

[andre_luis]

you should use something like that:

#define set_bit(x,y) (x |= 1 << y)
#define clr_bit(x,y) (x &= ~(1 << y))

Another set of usual macros:

#define toogle_bit(x,y) (x ^= 1 << y )
#define read_bit(x,y) ((x>> y) & 1 )

 

[Arrowspace]

why this will not work

#define clr_bit(x,y) (x=x|(0<<y))

 

[andre_luis]

The OR operator "|" that you are using above is not able to clear anything.
Just take a thorough look on the code which I gave, and try to understand how it works.