Continue to Site

Welcome to EDAboard.com

Welcome to our site! EDAboard.com is an international Electronics Discussion Forum focused on EDA software, circuits, schematics, books, theory, papers, asic, pld, 8051, DSP, Network, RF, Analog Design, PCB, Service Manuals... and a whole lot more! To participate you need to register. Registration is free. Click here to register now.

Register Log in

[SOLVED] Need help for reducing code length in PIC16F505

Status
Not open for further replies.
ankitvirdi4

ankitvirdi4

Member level 4
Joined
Mar 13, 2012
Messages
70
Helped
4
Reputation
8
Reaction score
4
Trophy points
1,288
Location
India
Activity points
1,926
Hello guys I coded a total of 32 sequences for my light sequencer circuit, I am trying to reverse engineer a local product which is 32 sequences light sequencer. I know that the product has 16F505 and I did everything and it works alright bt I can only fit in 25 sequences I want to fit all 32 sequences please help me out.
My code is
Code C - [expand]
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551

unsigned int s=0;
#include <htc.h> 
#include<pic.h>
#include "delay.h"
 
void delay()
{
  DelayMs(1);
}
void trigger()
{
PORTB|=(1<<0);
DelayUs(100);
PORTB&=~(1<<0);
DelayUs(100);
PORTB|=(1<<0);
}
void main()
{
OPTION = 0xDF;
TRISC=0x00;
TRISB=0b011110;
trigger();
while(1)
{
  if((RB2))
  {  
 
if(s==0)
   {
    PORTC=0b100000;
    delay();
    PORTC=0b010000;
    delay();
    PORTC=0b001000;
    delay();
    PORTC=0b000100;
    delay();
    PORTC=0b000010;
    delay();
    PORTC=0b000001;
    delay();
   }
  if(s==1)
   {
    PORTC=0b000001;
    delay();
    PORTC=0b000010;
    delay();
    PORTC=0b000100;
    delay();
    PORTC=0b001000;
    delay();
    PORTC=0b010000;
    delay();
    PORTC=0b100000;
    delay();
   }
  if(s==2)
   {
    PORTC=0b100001;
    delay();
    PORTC=0b010010;
    delay();
    PORTC=0b001100;
    delay();
    PORTC=0b001100;
    delay();
    PORTC=0b010010;
    delay();
    PORTC=0b100001;
    delay();
   }
    if(s==3)
 {
PORTC=0b000000;
delay();
delay();
PORTC=0b111111;
delay();
delay();
 }
  if(s==4)
 {
PORTC=0b000000;
delay();
PORTC=~PORTC;
delay();
 }
 if(s==5)
   {
    PORTC=0b011111;
    delay();
    PORTC=0b101111;
    delay();
    PORTC=0b110111;
    delay();
    PORTC=0b111011;
    delay();
    PORTC=0b111101;
    delay();
    PORTC=0b111110;
    delay();
   }
 if(s==6)
   {
    PORTC=0b111110;
    delay();
    PORTC=0b111101;
    delay();
    PORTC=0b111011;
    delay();
    PORTC=0b110111;
    delay();
    PORTC=0b101111;
    delay();
    PORTC=0b011111;
    delay();
   }
 if(s==7)
   {
    PORTC=0b011110;
    delay();
    PORTC=0b101101;
    delay();
    PORTC=0b110011;
    delay();
    PORTC=0b110011;
    delay();
    PORTC=0b101101;
    delay();
    PORTC=0b011110;
    delay();
   }
if(s==8)
   {
    PORTC=0b001100;
    delay();
    PORTC=0b001110;
    delay();
    PORTC=0b001111;
    delay();
    PORTC=0b001110;
    delay();
    PORTC=0b011100;
    delay();
    PORTC=0b111100;
    delay();
    PORTC=0b011100;
    delay();
    PORTC=0b001100;
    delay();
   }
  if(s==9)
 {
PORTC=0b111000;
delay();
PORTC=0b000111;
delay();
 }
if(s==10)
 {
PORTC=0b101010;
delay();
PORTC=0b010101;
delay();
 }
  if(s==11)
 {
 
PORTC=0b111111;
delay();
PORTC=0b110011;
delay();
PORTC=0b100001;
delay();
PORTC=0b000000;
delay();
 }
  if(s==12)
 {
 
PORTC=0b000000;
delay();
PORTC=0b001100;
delay();
PORTC=0b011110;
delay();
PORTC=0b111111;
delay();
 }
  if(s==13)
 {
PORTC=0b111111;
delay();
PORTC=0b011110;
delay();
PORTC=0b001100;
delay();
PORTC=0b000000;
delay();
 }
  if(s==14)
 {
 
PORTC=0b000000;
delay();
PORTC=0b100001;
delay();
PORTC=0b110011;
delay();
PORTC=0b111111;
delay();
 }
 if(s==15)
   {
    PORTC=0b001111;
    delay();
    PORTC=0b100111;
    delay();
    PORTC=0b110011;
    delay();
    PORTC=0b111001;
    delay();
    PORTC=0b111100;
    delay();
    PORTC=0b011110;
    delay();
    PORTC=0b111100;
    delay();
    PORTC=0b111001;
    delay();
    PORTC=0b110011;
    delay();
    PORTC=0b100111;
    delay();
    PORTC=0b001111;
    delay();
    PORTC=0b011110;
    delay();
   }
 
if(s==16)
   {
    PORTC=0b100000;
    delay();
    PORTC=0b010000;
    delay();
    PORTC=0b001000;
    delay();
    PORTC=0b000100;
    delay();
    PORTC=0b000010;
    delay();
    PORTC=0b000001;
    delay();
    PORTC=0b000001;
    delay();
    PORTC=0b000010;
    delay();
    PORTC=0b000100;
    delay();
    PORTC=0b001000;
    delay();
    PORTC=0b010000;
    delay();
    PORTC=0b100000;
    delay();
   }
 if(s==17)
 {
PORTC=0b100100;
delay();
PORTC=0b010010;
delay();
PORTC=0b001001;
delay();
 }
  if(s==18)
 {
PORTC=0b001001;
delay();
PORTC=0b010010;
delay();
PORTC=0b100100;
delay();
 }
if(s==19)
   {
    PORTC=0b100000;
    delay();
    PORTC=0b110000;
    delay();
    PORTC=0b111000;
    delay();
    PORTC=0b111100;
    delay();
    PORTC=0b111110;
    delay();
    PORTC=0b111111;
    delay(); 
    PORTC=0b011111;
    delay();
    PORTC=0b001111;
    delay();
    PORTC=0b000111;
    delay();
    PORTC=0b000011;
    delay();
    PORTC=0b000001;
    delay();
    PORTC=0b000000;
    delay();
   }
if(s==20)
   {
    PORTC=0b000001;
    delay();
    PORTC=0b000011;
    delay();
    PORTC=0b000111;
    delay();
    PORTC=0b001111;
    delay();
    PORTC=0b011111;
    delay();
    PORTC=0b111111;
    delay(); 
    PORTC=0b111110;
    delay();
    PORTC=0b111100;
    delay();
    PORTC=0b111000;
    delay();
    PORTC=0b110000;
    delay();
    PORTC=0b100000;
    delay();
    PORTC=0b000000;
    delay();
   }
 
if(s==21)
   {
    PORTC=0b100000;
    delay();
    PORTC=0b110000;
    delay();
    PORTC=0b111000;
    delay();
    PORTC=0b111100;
    delay();
    PORTC=0b111110;
    delay();
    PORTC=0b111111;
    delay();
    PORTC=0b111110;
    delay();
    PORTC=0b111100;
    delay();
    PORTC=0b111000;
    delay();
    PORTC=0b110000;
    delay();
    PORTC=0b100000;
    delay();
    PORTC=0b000000;
    delay();
   }
if(s==22)
   {
    PORTC=0b000001;
    delay();
    PORTC=0b000011;
    delay();
    PORTC=0b000111;
    delay();
    PORTC=0b001111;
    delay();
    PORTC=0b011111;
    delay();
    PORTC=0b111111;
    delay();
    PORTC=0b011111;
    delay();
    PORTC=0b001111;
    delay();
    PORTC=0b000111;
    delay();
    PORTC=0b000011;
    delay();
    PORTC=0b000001;
    delay();
    PORTC=0b000000;
    delay();
   }
  if(s==23)
 {
PORTC=0b111000;
delay();
PORTC=0b011100;
delay();
PORTC=0b001110;
delay();
PORTC=0b000111;
delay();
PORTC=0b100011;
delay();
PORTC=0b110001;
delay();
 }
  if(s==24)
 {
PORTC=0b000111;
delay();
PORTC=0b001110;
delay();
PORTC=0b011100;
delay();
PORTC=0b111000;
delay();
PORTC=0b110001;
delay();
PORTC=0b100011;
delay();
 } 
  if(s==25)
 {
PORTC=0b110000;
delay();
PORTC=0b001100;
delay();
PORTC=0b000000;
delay();
PORTC=0b001100;
delay();
PORTC=0b000011;
delay(); 
}
  if(s==26)
 {
PORTC=0b000011;
delay();
PORTC=0b001100;
delay();
PORTC=0b000000;
delay();
PORTC=0b001100;
delay();
PORTC=0b110000;
delay(); 
}
  if(s==27)
 {
PORTC=0b110000;
delay();
PORTC=0b001100;
delay();
PORTC=0b000011;
delay(); 
}
  if(s==28)
 {
PORTC=0b000011;
delay();
PORTC=0b001100;
delay();
PORTC=0b110000;
delay(); 
}
  if(s==29)
 {
PORTC=0b110000;
delay();
PORTC=0b001100;
delay();
PORTC=0b000011;
delay();
PORTC=0b000011;
delay();
PORTC=0b001100;
delay();
PORTC=0b110000;
delay(); 
}
  if(s==30)
 {
PORTC=0b111000;
delay();
PORTC=0b000000;
delay();
PORTC=0b011100;
delay();
PORTC=0b000000;
delay();
PORTC=0b001110;
delay();
PORTC=0b000000;
delay();
PORTC=0b000111;
delay();
PORTC=0b000000;
delay();
PORTC=0b100011;
delay();
PORTC=0b000000;
delay();
PORTC=0b110001;
delay();
PORTC=0b000000;
delay();
 }
  if(s==31)
 {
PORTC=0b000111;
delay();
PORTC=0b000000;
delay();
PORTC=0b001110;
delay();
PORTC=0b000000;
delay();
PORTC=0b011100;
delay();
PORTC=0b000000;
delay();
PORTC=0b111000;
delay();
PORTC=0b000000;
delay();
PORTC=0b110001;
delay();
PORTC=0b000000;
delay();
PORTC=0b100011;
delay();
PORTC=0b000000;
delay();
 }
if(s==32)
{
s=0;
}
}
 else
  {
   s++;
  trigger();
}
}
}


I tried using loops and rotating the port value but it still eats up space.
 

You can use switch instead if...else command.
Also, think about use a look-up table to take values charged at Ports.


+++
 
can you give an example on how to use a look up table? please?
 

You can take values from a structure, just pointing it at the switch command.


+++
 

Why are you using software delay routines other than those provided by the Hi-Tech Compiler?

Utilizing a Timer with an accompanying Interrupt Service Routine (ISR) to generate the required delays would certainly free up a significant amount of code storage.

Also remove the following:

Code: 
#include<pic.h>

As it is not required, the htc.h header file includes the appropriate device specific header file as well as the default compiler routines.

I also agree with Andre, the implementation of a lookup table would most likely be beneficial.

If conservation of code storage is of utmost importance the app could be written in Assembly language, which would probably leave room to spare.


BigDog
 
Status
Not open for further replies.

Similar threads

Part and Inventory Search

Welcome to EDABoard.com

Sponsor

Back
Top