[SOLVED] If else statement not working with PIC16F886

[freemanantony]

hai everybody,
i have done code for current measurement in Pic 16F886 and after measuring current need to switch off output if the current measured is more than the maximum current, but when comparing if the current is less than maximum current it is not hitting the else condition. i am attaching my code here

 R_Phase_curr: ADCON0 = 0xA9 ;      //0x69  //0xA9          // reading R_ phase current// Changed ADC conversion clock to Fosc/32 from Fosc/8
    delay(10);
    adc_do();
       current_R = adc_val;
       if(current_R > MAX_CURRENT)                                                                                                                                                                                                                       if(current_R > MAX_CURRENT)
       {
          
            R_Phase_ol = 1;
        
            ALERT_FR = 1;
       }
       else if (current_R < MAX_CURRENT)
       {
            R_Phase_ol = 0;
           ALERT_FR = 0;
               
       }

adc_val, curent_R and MAX_CURENT are unsigned long variables
can anyone help me on this ?

 

[KlausST]

Hi,

I wonder: why there is twice the same "if(current_R > MAX_CURRENT)" immediately after the other?

******
Maybe this happens:
Everything works fine, until the current is over the limit
Then it is switched OFF
Then because it is switched OFF obviously the current goes to zero
Then the current is measured again (loop)
Because it now it is zero...the load is switched ON
For sure the current rises
It is measured again
Maybe it now again it is over the limit
Therfore it is switched OFF again
..then ON again
..then OFF again
And so on..

Klaus

 

[Easyrider83]

 R_Phase_curr: ADCON0 = 0xA9 ;      //0x69  //0xA9          // reading R_ phase current// Changed ADC conversion clock to Fosc/32 from Fosc/8
    delay(10);
    adc_do();
       current_R = adc_val;
       if(current_R > MAX_CURRENT)                                                                                                                                                                                                                       if(current_R > MAX_CURRENT)
       {
          
            R_Phase_ol = 1;
        
            ALERT_FR = 1;
       }
       else
       {
            R_Phase_ol = 0;
           ALERT_FR = 0;
               
       }

Try this

 

[freemanantony]

one condition is (current_R > MAX_CURRENT) and other is (current_R < MAX_CURRENT), even when current is within limits it is not hitting the else if condition

- - - Updated - - -

easyrider i tired that too it hitting the if condition when that condition is true but
not hitting the else condition when that condition is false

 

[KlausST]

Hi,

Copied from your code:

       current_R = adc_val;
     [COLOR="#FF0000"]  if(current_R > MAX_CURRENT)                                                                                                                                                                                                                       if(current_R > MAX_CURRENT)[/COLOR]
       {

Klaus

 

[freemanantony]

thank you klausSt for pointing out the mistake my bad sorry