How to draw Electrical circuit???

[life24]

Hi,
I want write few program with bascom for mega16 in proteus program.
Now i should draw electrical circuit with mega16 and one 7-seg.
I right draw?
Please see the attachment.

 

[KlausST]

Hi,

on first sight it seems ok.
But the display seems to be an 4 x 7- segment LED display.
It is in multiplexing technique. Mind that the current on the digit wires (1, 2 , 3, 4) must handle max. 8 x LED current.
Now it depends on the LED current if the AVR can source current.
Also mind that with multiplexing the digits only are alight 1/4 of time and therefore they need about 4 times the current of a non multiplexed display.
Does the display need external currentlimiting circuitry (simplest is a resistor)
How do you adjust for brightness?

Good luck with your project

Edit1:corrected some mistakes

 

[Amin Khorsandi]

if you want to make a simulation, it works. but in practical you will need serial resistors in 7seg's lines. and probably transistor driver for common pins.