error in spi write function

[hemnath]

I'm learning spi mode. Using CCS c compiler.

this is the routine for spi write,

void SPI_Write(unsigned char addr,unsigned char data)
{
  // Activate the SS SPI Select pin
  PORT_C6 = 0;

  // Start MCP23S17 OpCode transmission
  SSPBUF = SPI_SLAVE_ID | ((SPI_SLAVE_ADDR << 1) & 0x0E)| SPI_SLAVE_WRITE;

  // Wait for Data Transmit/Receipt complete
  while(!BF);

  // Start MCP23S17 Register Address transmission
  SSPBUF = addr;

  // Wait for Data Transmit/Receipt complete
  while(!BF);            

  // Start Data transmission
  SSPBUF = data;

  // Wait for Data Transmit/Receipt complete
  while(!BF);

  // CS pin is not active
  PORT_C6 = 1;
}

In main loop,

  SPI_Write(IOCONA,0x28);   // I/O Control Register: BANK=0, SEQOP=1, HAEN=1 (Enable Addressing)
  SPI_Write(IODIRA,0x00);   // GPIOA As Output
  SPI_Write(IODIRB,0xFF);   // GPIOB As Input
  SPI_Write(GPPUB,0xFF);    // Enable Pull-up Resistor on GPIOB
  SPI_Write(GPIOA,0x00);    // Reset Output on GPIOA

But the errors are points to the main loop in the SPI_Write,
Errors shown are,
*** Error 58 "main.c" Line 112(20,24): Expecting a close paren
*** Error 58 "main.c" Line 113(20,24): Expecting a close paren
*** Error 58 "main.c" Line 114(20,24): Expecting a close paren
*** Error 58 "main.c" Line 115(19,23): Expecting a close paren
*** Error 58 "main.c" Line 116(19,23): Expecting a close paren

Thanks in advance

 

[anboli]

i think the error was not in this routine, it is affected by previous loop or line. could you post full main function?

 

[hemnath]

#include "18F2520.h"
#include "f2420_regs.h"
#fuses HS
#use delay(clock = 20000000)

// MCP23S17 SPI Slave Device
#define SPI_SLAVE_ID    0x40
#define SPI_SLAVE_ADDR  0x00      // A2=0,A1=0,A0=0
#define SPI_SLAVE_WRITE 0x00
#define SPI_SLAVE_READ  0x01

// MCP23S17 Registers Definition for BANK=0 (default)
#define IODIRA 0x00
#define IODIRB 0x01
#define IOCONA 0x0A
#define GPPUA  0x0C
#define GPPUB  0x0D
#define GPIOA  0x12
#define GPIOB  0x13

static rom unsigned char led_patern[32] = {0b00000001,0b00000011,0b00000110,0b00001100,0b00011001,  
  	 			                           0b00110011,0b01100110,0b11001100,0b10011000,0b00110000,	
		   			                       0b01100000,0b11000000,0b10000000,0b00000000,0b00000000,
				                           0b00000000,0b10000000,0b11000000,0b01100000,0b00110000,				                    
										   0b10011000,0b11001100,0b01100110,0b00110011,0b00011001,
                    	                   0b00001100,0b00000110,0b00000011,0b00000001,0b00000000,
										   0b00000000,0b00000000};

void SPI_Write(unsigned char addr,unsigned char data)
{
  // Activate the SS SPI Select pin
  PORT_C6 = 0;

  // Start MCP23S17 OpCode transmission
  SSPBUF = SPI_SLAVE_ID | ((SPI_SLAVE_ADDR << 1) & 0x0E)| SPI_SLAVE_WRITE;

  // Wait for Data Transmit/Receipt complete
  while(!BF);

  // Start MCP23S17 Register Address transmission
  SSPBUF = addr;

  // Wait for Data Transmit/Receipt complete
  while(!BF);            

  // Start Data transmission
  SSPBUF = data;

  // Wait for Data Transmit/Receipt complete
  while(!BF);

  // CS pin is not active
  PORT_C6 = 1;
}

unsigned char SPI_Read(unsigned char addr)
{
  // Activate the SS SPI Select pin
  PORT_C6 = 0;

  // Start MCP23S17 OpCode transmission
  SSPBUF = SPI_SLAVE_ID | ((SPI_SLAVE_ADDR << 1) & 0x0E)| SPI_SLAVE_READ;

  // Wait for Data Transmit/Receipt complete
  while(!BF);

  // Start MCP23S17 Address transmission
  SSPBUF = addr;

  // Wait for Data Transmit/Receipt complete
  while(!BF);  

  // Send Dummy transmission for reading the data
  SSPBUF = 0x00;

  // Wait for Data Transmit/Receipt complete
  while(!BF);  

  // CS pin is not active
  PORT_C6 = 1;

  return(SSPBUF);
}

void main()
{
  unsigned char cnt,togbutton,inp;
  unsigned int idelay;

  TRISC = 0x00;        // Set All on PORTC as Output
  TRISA = 0x30;        // Input for RA4 and RA5
  TRISB = 0x00;
 // ANSEL = 0x08;        // Set PORT AN3 to analog input
 // ANSELH = 0x00;       // Set PORT AN8 to AN11 as Digital I/O

  /* Init the PIC18F2520 ADC Peripheral */
  ADCON0=0b00001101;   // ADC port channel 3 (AN3), Enable ADC
  ADCON1=0b00000000;   // Use Internal Voltage Reference (Vdd and Vss)
  ADCON2=0b10101011;   // Right justify result, 12 TAD, Select the FRC for 16 MHz

  /* Initial the PIC18F2520 SPI Peripheral */
  TRIS_C6 = 0;  // RC6/SS - Output (Chip Select)
  TRIS_C7= 0;   // RC7/SDO - Output (Serial Data Out)
  TRIS_B4= 1;   // RB4/SDI - Input (Serial Data In)
  TRIS_B6= 0;   // RB6/SCK - Output (Clock)

  SSPSTAT = 0x40;        // Set SMP=0 and CKE=1. Notes: The lower 6 bit is read only
  SSPCON1 = 0x20;        // Enable SPI Master with Fosc/4
  PORT_C6 = 1;     		 // Disable Chip Select

  // Initial the MCP23S17 SPI I/O Expander
  SPI_Write(IOCONA,0x28);   // I/O Control Register: BANK=0, SEQOP=1, HAEN=1 (Enable Addressing)
  SPI_Write(IODIRA,0x00);   // GPIOA As Output
  SPI_Write(IODIRB,0xFF);   // GPIOB As Input
  SPI_Write(GPPUB,0xFF);    // Enable Pull-up Resistor on GPIOB
  SPI_Write(GPIOA,0x00);    // Reset Output on GPIOA

  // Initial Variable Used
  togbutton=0;              // Toggle Button
  cnt=0;
  idelay=100;               // Default Delay;   

for(;;) {
    inp=SPI_Read(GPIOB);    // Read from GPIOB
	if (inp == 0xFE) {      // Button is pressed
	  delay_ms(1);		 

	  inp=SPI_Read(GPIOB);  // Read from GPIOB, for simple debounce
	  if (inp == 0xFE) togbutton^=0x01;

	  if (togbutton == 0x00) {
	    SPI_Write(GPIOA,0x00); // Write to MCP23S17 GPIOA
	    cnt=0;
      }
	}

    if (togbutton) {
      GO=1;
      while (GO);   // Wait conversion done

      idelay=ADRESL;           // Get the 8 bit LSB result
      idelay += (ADRESH << 8); // Get the 2 bit MSB result   

      // Write to GPIOA
      SPI_Write(GPIOA,led_patern[cnt++]);
      if(cnt >= 32) cnt=0;
    }
    delay_ms(idelay);          // Call Delay function
  }
}

 

[alexxx]

In which lines do you get the error? Mark them with red color. I can't follow the code without knowing where to search.

 

[hemnath]

Errors are found in this lines,

SPI_Write(IOCONA,0x28); // I/O Control Register: BANK=0, SEQOP=1, HAEN=1 (Enable Addressing)
SPI_Write(IODIRA,0x00); // GPIOA As Output
SPI_Write(IODIRB,0xFF); // GPIOB As Input
SPI_Write(GPPUB,0xFF); // Enable Pull-up Resistor on GPIOB
SPI_Write(GPIOA,0x00); // Reset Output on GPIOA

SPI_Write(GPIOA,0x00); // Write to MCP23S17 GPIOA

SPI_Write(GPIOA,led_patern[cnt++]);

These are the errors shown on my compiler(CCS C compiler),

*** Error 58 "main.c" Line 112(20,24): Expecting a close paren
*** Error 58 "main.c" Line 113(20,24): Expecting a close paren
*** Error 58 "main.c" Line 114(20,24): Expecting a close paren
*** Error 58 "main.c" Line 115(19,23): Expecting a close paren
*** Error 58 "main.c" Line 116(19,23): Expecting a close paren
*** Error 58 "main.c" Line 132(21,25): Expecting a close paren
*** Error 58 "main.c" Line 145(23,33): Expecting a close paren

 

[alexxx]

This is strange, it seems to be OK.
I would try to write a line like

SPI_Write(1,2);

and see if it compiles. But don't copy - paste it from another line. Write it manually.

 

[hemnath]

Thanks alex for your kind reply.
I have found the problem and corrected it already. But i don't have internet to reply you back.

CCS already have the inbuilt function called SPI_Write();
In my program, i have also used the same name. Now I have changed the function name from spi_write to spi_write1();

now the problem is solved.