[SOLVED] when i use array with with function the compiler assign as an error in the data type

[mahm150]

my code
declare the function
****************
void arrange_message(unsigned char data_wrtn[16],unsigned char data_order);

call the function.
**************
arrange_message(THREE[j],1);

definition of function
*****************
oid arrange_message(unsigned char data_wrtn[16],unsigned char data_order)
{
unsigned char p;
if(data_order==1)
for(p=0;p<=7;p++)
{ temp1[p]= data_wrtn[p];}
}
****************************************
the error message of compiler is
parameter #1 of type unsigned char[] is compatible with type unsigned char[] specified in the
function arrange _message

 

[qwertyuiop415263]

oid arrange_message(unsigned char data_wrtn[16],unsigned char data_order)

typing error in above line, it should be

void arrange_message(unsigned char data_wrtn[16],unsigned char data_order)

---------- Post added at 16:10 ---------- Previous post was at 16:08 ----------

By the way this is not a complete code. there must be a main function.

 

[andre_luis]

You cannot manage some data wich was already pointed by function call.
Maybe, the correct declaration of 1rst argument should be without vector, despite you input a vector during function call :

void arrange_message(unsigned char [B]data_wrtn[/B] , unsigned char data_order);

+++

 

[mahm150]

for andre_teprom
in the defination of function define as vector or not

 

[alexan_e]

The array should be passed to the function using a pointer

**broken link removed**

Alex

 

[andre_luis]

According declaration code presented at post #3 and pointer indexing sugested by alexan_e, you could perform a single change at your program :

{ temp1[p]= *( &data_wrtn + p ) ;}

Note : I´m not sure anymore about pointer sintax, so some correction coud be done.

+++

 

[mahm150]

when i use pointer as in the alexan_e it work but the dat in the array isnt correct
void arrange_message(unsigned char *,unsigned char data_order); with the code
****************************************

void arrange_message(unsigned char data_wrtn[],unsigned char data_order)
{
unsigned char p;
if(data_order==1)
{
for(p=0;p<=15;p++)
{
temp1[p]= data_wrtn[p];
}
}
}

 

[andre_luis]

It is missing the input argument variable declaration :

void arrange_message(unsigned char * (???) ,unsigned char data_order);

+++

 

[alexan_e]

Are calling the function like arrange_message(THREE,1);

Alex

 

[mahm150]

yes i call function like arrange_message(THREE,1);

 

[alexan_e]

What is wrong exactly,l the value of temp1?
post your code

Alex

 

[mahm150]

for andre_teprom i write as in the alex link
**broken link removed**

 

[andre_luis]

Try this :

declare the function
****************
void arrange_message(unsigned char data_wrtn ,unsigned char data_order);

call the function.
**************
arrange_message(THREE[j],1);

definition of function
*****************
oid arrange_message(unsigned char data_wrtn , unsigned char data_order)
{
unsigned char p;
if(data_order==1)
for(p=0;p<=7;p++)
{ temp1[p]= *(&data_wrtn+p);}
}
****************************************

I did changes according what was sugested above.

+++

 

[alexan_e]

if you pass a char parameter than you can't use it as an address to get the rest of the array data, the memory position of this variable is not related to the array so you can't read the rest of the array like a contiguous memory space.

Alex

 

[mahm150]

for alex this is my code
****************
arrange_message(THREE,1);
******************************

void arrange_message(unsigned char data_wrtn[],unsigned char data_order)
{
unsigned char p;
if(data_order==1)
{
for(p=0;p<=15;p++)
{
temp1[p]= data_wrtn[p];
}
}
}
*****************************************************************
THREE [16]={0x00,0x40,0x60,0x30,0x18,0x18,0x1C,0x0c,0x0c,0x0c,0x0c,0xFC,0xFc,0xAC,0x00,0x00};
*******************************************

---------- Post added at 18:41 ---------- Previous post was at 18:34 ----------

for andre_teprom
i try your code but it not work ok the data in is the address location of sram

 

[alexan_e]

and how do you check the value of temp1?
what was the value of temp1?

Alex

 

[mahm150]

if you pass a char parameter than you can't use it as an address to get the rest of the array data, the memory position of this variable is not related to the array so you can't read the rest of the array like a contiguous memory space.

Alex

what do u mean ?

---------- Post added at 18:46 ---------- Previous post was at 18:44 ----------

and how do you check the value of temp1?
what was the value of temp1?

Alex

i see it avr simulator

 

[andre_luis]

He refered to the implementation I sugested.
Despite works many times, is not guaranteed everytime, due dynamic memory management is performed by compiler, and I was competiting with it.

+++

 

[mahm150]

 

[alexan_e]

I have no idea why you see wrong data but I have seen AVR studio sometime show stupid values in variables or not update them.
Can you try with temp1[p]= THREE [p]; (make THREE a global variable first)
to see if you get correct result

Alex