[PIC] PROTB Pullup issues after changing code from PIC16F876a to PIC16F886

[ghead]

Hi, Im currently having a problem of PORTB not seeming to enable internal pull-ups. I have changed the code from PIC16F876a to PIC16F886 and have maybe missed something as I am new to c proramming.
Here is how the pull-ups are set in code (afaik)

//-- PORTS
   output_A(0x00);
   output_B(0x00);
   output_C(0x00);
   set_tris_A(0b11011111);
   port_B_pullups(true);
   set_tris_B(0b11111111);
   set_tris_C(0b00000000);

Also when compiling after changing PIC I get an error with this line setup_adc_ports(RA0_RA1_RA3_ANALOG);
Which I blanked out on a test it everything seemed to work fine with adc so not sure if this line is even necessary??


Ive attached full code but these seem to be the relevant lines above, Also been through datasheets to check port functions arn't conflicting and everything seems fine to me...

Any help much appreciated.

 

[xenos]

The 886 has 11 ADC in stead of 876A with 5.
Have a look on other differences: https://www.microchip.com/wwwproducts/ProductCompare.aspx?product1=PIC16F876A&product2=PIC16F886

Your problem is that some of the RB? pins, have ADC functions so you cannot use them as Digital IO with internal pull ups, unless you disable ADC.

- - - Updated - - -

Check register: ADCON0
page 106 of pdf: https://ww1.microchip.com/downloads/en/DeviceDoc/41291D.pdf

 

[milan.rajik]

Attached is the fixed project.