pic18f project
Hi Nick7!
It can be good idea if you consider some faster external AD, and make oscilloscope capable to see faster signals.
As I see things, with 50k samples you can see only 25Khz, or less, and it can be easily reached with any sound card and free software.
Also, power of digital oscilloscopes is in data storage function, so need to consider some data logging.
Logic analyzer is also very useful tool, which can be integrated in digital oscilloscope project.