problem with rotary encoder

[mohamed.elsabagh]

I am using a rotary encoder with a switch button, I am using c8051f340 microcontroller to detect the encoder movement on external interrupt, but the problem is that sometimes the code detect the clock wise movement as anticlock wise and vice versa i don't know what is the wrong, is there a problem with the rotary encoder itself.

 

[internetuser2k12]

post your code

 

[mohamed.elsabagh]

void External_Interrupt1() interrupt INTERRUPT_INT1
{
// the interrupt is on negative edge trigger of B

if(encoder_state != encoder_unknown) ///// The last state of the encoder is not yet read by other layers
{
return;
}
else
{
//// This code applies only when B is on interrupt
if((ENCODER_PORT & ENCODER_A_MASK) == 0x00) /// check wether A is 0 or 1
{
encoder_state = encoder_CW;
}
else
{
encoder_state = encoder_CCW;
}
}
}

 

[FvM]

To get full encoder resolution, you'll want to process all edges of A and B output. PIC port change interrupt is a good way to implement it. For moderate encoder speeds, a fast timer interrupt can do as well.

I wonder about the purpose of huge 100 nF capacitors parallel to the encoder switches. They are causing unwanted delays and large discharge currents that stress the switches.

 

[alexxx]

You must implement a state machine to get direction and speed. Read wikipedia's article especially the "Incremental rotary encoder" part. Both state machines for the two directions are shown in the two tables there.
https://en.wikipedia.org/wiki/Rotary_encoder

Make sure that the pin change interrupt has a high priority, otherwise you will lose counts and this will drive your algorithm to fault conclusions.

Also it is common practice to use schmitt trigger gates in series with the A, B signals.