problem with ISE testbench

[fateme m]

i have a simple code i synthesized it no errors or warnings but after simulating it there is a problem ! the code is supposed to do this:
in the input there is a pulse wave if the period of the input pulse is more or equal to 1 ms the input goes to the output but if the period of the input pulse is less than 1 ms, a pulse withe a period of 1 ms goes to the output(frequency of the board is 50 MHz) the problem is the ON-time FOR the input instead of being 1 is X!!!! can't figure out what the problem is:bang::bang:
here is the code , the test bench code and the picture of simulation:

Code:

---

Code VHDL - [expand]
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
----------------------------------------------------------------------------------
-- Company: 
-- Engineer: 
-- 
-- Create Date:    19:39:42 06/13/2015 
-- Design Name: 
-- Module Name:    limit_s - Behavioral 
-- Project Name: 
-- Target Devices: 
-- Tool versions: 
-- Description: 
--
-- Dependencies: 
--
-- Revision: 
-- Revision 0.01 - File Created
-- Additional Comments: 
--
----------------------------------------------------------------------------------
library IEEE;
use IEEE.STD_LOGIC_1164.ALL;
 
-- Uncomment the following library declaration if using
-- arithmetic functions with Signed or Unsigned values
--use IEEE.NUMERIC_STD.ALL;
 
-- Uncomment the following library declaration if instantiating
-- any Xilinx primitives in this code.
--library UNISIM;
--use UNISIM.VComponents.all;
 
entity limit_s is
    Port ( in1 : inout  STD_LOGIC:='0';
           out1 : out  STD_LOGIC:='0';
              clk : in STD_LOGIC);
end limit_s;
 
architecture Behavioral of limit_s is
signal d: std_logic:='0';
signal flag: std_logic:='0';
signal cnt : integer range 0 to 50000;
signal cnt1 : integer range 0 to 25000;
 
begin
process(clk)
    begin
    if (rising_edge(clk))then
       cnt1<=cnt1+1;
        if (cnt1=25000)then
          cnt1<=0;
          d<=not d;
        end if;
        if (in1='1')then
            cnt<=cnt+1;
            if(cnt>=25000)then
                flag<='1';          
                else
                flag<='0';
            end if;     
        end if; 
    end if;
end process;
 
process(clk)
begin
if (rising_edge(clk))then
    if (flag='1')then
        out1<=in1;
        else
        out1<=d;
    end if;
end if;
end process;
end Behavioral;

---

testbench:

---

Code VHDL - [expand]
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
--------------------------------------------------------------------------------
-- Company: 
-- Engineer:
--
-- Create Date:   23:32:23 06/13/2015
-- Design Name:   
-- Module Name:   D:/ISE_PROJECTS/speed_limit/speed_limit_tb.vhd
-- Project Name:  speed_limit
-- Target Device:  
-- Tool versions:  
-- Description:   
-- 
-- VHDL Test Bench Created by ISE for module: limit_s
-- 
-- Dependencies:
-- 
-- Revision:
-- Revision 0.01 - File Created
-- Additional Comments:
--
-- Notes: 
-- This testbench has been automatically generated using types std_logic and
-- std_logic_vector for the ports of the unit under test.  Xilinx recommends
-- that these types always be used for the top-level I/O of a design in order
-- to guarantee that the testbench will bind correctly to the post-implementation 
-- simulation model.
--------------------------------------------------------------------------------
LIBRARY ieee;
USE ieee.std_logic_1164.ALL;
 
-- Uncomment the following library declaration if using
-- arithmetic functions with Signed or Unsigned values
--USE ieee.numeric_std.ALL;
 
ENTITY speed_limit_tb IS
END speed_limit_tb;
 
ARCHITECTURE behavior OF speed_limit_tb IS 
 
    -- Component Declaration for the Unit Under Test (UUT)
 
    COMPONENT limit_s
    PORT(
         in1 : INOUT  std_logic:='0';
         out1 : OUT  std_logic;
         clk : IN  std_logic
        );
    END COMPONENT;
    
 
   --Inputs
   signal clk : std_logic := '0';
 
    --BiDirs
   signal in1 : std_logic;
   signal out1 : std_logic;
 
BEGIN
 
    -- Instantiate the Unit Under Test (UUT)
   uut: limit_s PORT MAP (
          in1 => in1,
          out1 => out1,
          clk => clk
        );
 
   -- Clock process definitions
   clk_process :process
   begin
        clk <= '0';
        wait for 10 ns;
        clk <= '1';
        wait for 10 ns;
   end process;
    
 
   process
   begin
        in1 <= '0';
        wait for 0.6 ms;
        in1 <= '1';
        wait for 0.6 ms;
   end process;
    
 
END;

---

 

[std_match]

Why is in1 of type "inout"? You assign '0' to it in the declaration and never assign anything else.
When you try to drive it as an input with '1' there is a conflict ('X').
An inout must be driven with 'Z' to be used as an input.
In this case you should not use "inout". Use "in" instead.

 

[fateme m]

Thank you I had forgotten about that .but after making that change, I understood the code is not correct. because after simulating, flag is always '1' so it gives whatever in the in1, to out1!!! I believe cnt should become 0 somewhere, i tried that but again it didn't work!:-( can you help again?

 

[TrickyDicky]

Thas because cnt never gets reset, hence flag will be set high once the threshold is reached and never go back to 0

 

[fateme m]

I know that, donno how to solve that!:-?

 

[TrickyDicky]

Why not reset the cnt value?