[PIC] P18f1330 output error

[ruben91]

I have fix my code to test Hc-Sr04 sensor and its working fine, but there is one problem i'm facing now. which is the output(LED) is not light up as bright as it should even without resistor, but it is very dim. Even i test with voltmeter it shows 5v in the output pin. But when i test it with buzzer, the buzzer keeps buzzing, I don't know where i went wrong, Pls help me with this, any help is much appreciated

#include<p18f1330.h>
#include<delays.h>
#include <math.h>

#pragma config WDT=OFF
#pragma config OSC=INTIO2
#pragma config PWRT=ON

unsigned int a;
unsigned int time;

void main()

{
OSCCONbits.IRCF2 = 1;// 4mhz OSC
OSCCONbits.IRCF1 = 1;//
OSCCONbits.IRCF0 = 0;//

TRISBbits.TRISB4=0; // trig
TRISBbits.TRISB5=1; //echo
TRISAbits.TRISA2=0; //RED led
TRISAbits.TRISA3=0; //GREEN led




while(1)
{
PORTBbits.RB4=0;
PORTBbits.RB5=0;
PORTAbits.RA2=0;
PORTAbits.RA3=0;

TMR1H= 0;
TMR1L= 0;

	PORTBbits.RB4=1;
Delay10TCYx(1);
	PORTBbits.RB4=0;


while(PORTBbits.RB5 == 0);                      //If ECHO is HIGH
    T1CONbits.TMR1ON = 1;                       //Start Timer
while(PORTBbits.RB5 == 1);                      //If ECHO is LOW   
	T1CONbits.TMR1ON = 0;                     //Stop Timer
     // a = (TMR1L | (TMR1H<<8))/58.82; //Calculate Distance
//Delay10KTCYx(255);
//Delay10KTCYx(255);

time= TMR1H;
time= time<<8;
time= time|TMR1L;
a = time/58;	
PIR1bits.TMR1IF=0;
Delay10TCYx(60);
//Delay10KTCYx(255);
//Delay10KTCYx(255);
    


if(a<=400)
{
PORTAbits.RA2=1; //red
}

if(a<=2000)
{
//PORTAbits.RA3=1;  //green
LATAbits.LATA3=1;
}
//Delay10KTCYx(255);
}
}

 

[betwixt]

Your code would be much easier to read if you #defined the pin names. For example:

#define PORTAbits.RA2 RedLED
#define PORTAbits.RA3 GreenLED

you can then use constructs like 'RedLED = 1;' which are far easier to follow. (and type!)

I think your underlying problem is that you turn the LEDs off each time you enter the while(1) loop so they are pulsing instead of staying on. You should be using LAT instead of PORT for the output statements too for best reliability.

Brian.