nested for loops running forever

[gsbkbharath]

This is the part of my code for histogram segmentation. It has to read data from in[j] into a temporary variable n which is the intensity of that pixel.Then it has to increment the nth bit of the hist vector by 1 so that at the end the vector hist has the requires histogram values.But the loop is RUNNING FOREVER.Can someone help with this please?

always@(posedge clk)
begin
for (i=0;i<=2;i=i+1)
begin
for (j=0;j<=2;j=j+1)
begin
n = in[j];
hist[n] = hist[n]+1'b1;
end
end
end

 

[dave_59]

show the declarations of every variable in your example.

 

[ads-ee]

using the following to "test" your code in Modelsim 10.1b. It ran fine for the 256 clock cycles.

---

Code Verilog - [expand]
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
module test2;
 
reg [3:0] in [0:2][0:2];
reg [3:0] n;
 
reg [7:0] hist [0:15];
 
reg [7:0] count = 8'b0;
 
reg clk;
 
integer i,j;
 
initial begin
  clk = 1'b0;
  hist[ 0] = 8'b0;
  hist[ 1] = 8'b0;
  hist[ 2] = 8'b0;
  hist[ 3] = 8'b0;
  hist[ 4] = 8'b0;
  hist[ 5] = 8'b0;
  hist[ 6] = 8'b0;
  hist[ 7] = 8'b0;
  hist[ 8] = 8'b0;
  hist[ 9] = 8'b0;
  hist[10] = 8'b0;
  hist[11] = 8'b0;
  hist[12] = 8'b0;
  hist[13] = 8'b0;
  hist[14] = 8'b0;
  hist[15] = 8'b0;
 
  forever begin
    clk = 1'b0;
    #5;
    clk = 1'b1;
    #5;
  end
end
 
// generate test data
always @ (posedge clk) begin
  in[0][0] <= $random;
  in[0][1] <= $random;
  in[0][2] <= $random;
  in[1][0] <= $random;
  in[1][1] <= $random;
  in[1][2] <= $random;
  in[2][0] <= $random;
  in[2][1] <= $random;
  in[2][2] <= $random;
  count <= count + 8'b1;
 
  if ( &count ) $stop;
end
 
 
always @(posedge clk) begin
  for (i=0;i<=2;i=i+1) begin
    for (j=0;j<=2;j=j+1) begin
      n <= in[i][j];
      hist[n] <= hist[n]+1'b1;
    end
  end
end
 
endmodule

---

I'm assuming this is non-synthesizable testbench code, because there are blocking statements in the always block. I attempted to synthesize the code to see what those blocking statements would generate but the results didn't make much sense. I used ISE 13.3, probably should have used Quartus II 12 as I've had issues with ISE RTL schematic generation.

 

[gsbkbharath]

Yes the mistake was with declarations.i declared the variables i,j as one bit register instead of 2 bits.So, the loop for j never closed.Anyway thanks.

- - - Updated - - -

using the following to "test" your code in Modelsim 10.1b. It ran fine for the 256 clock cycles.

---

Code Verilog - [expand]
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
module test2;
 
reg [3:0] in [0:2][0:2];
reg [3:0] n;
 
reg [7:0] hist [0:15];
 
reg [7:0] count = 8'b0;
 
reg clk;
 
integer i,j;
 
initial begin
  clk = 1'b0;
  hist[ 0] = 8'b0;
  hist[ 1] = 8'b0;
  hist[ 2] = 8'b0;
  hist[ 3] = 8'b0;
  hist[ 4] = 8'b0;
  hist[ 5] = 8'b0;
  hist[ 6] = 8'b0;
  hist[ 7] = 8'b0;
  hist[ 8] = 8'b0;
  hist[ 9] = 8'b0;
  hist[10] = 8'b0;
  hist[11] = 8'b0;
  hist[12] = 8'b0;
  hist[13] = 8'b0;
  hist[14] = 8'b0;
  hist[15] = 8'b0;
 
  forever begin
    clk = 1'b0;
    #5;
    clk = 1'b1;
    #5;
  end
end
 
// generate test data
always @ (posedge clk) begin
  in[0][0] <= $random;
  in[0][1] <= $random;
  in[0][2] <= $random;
  in[1][0] <= $random;
  in[1][1] <= $random;
  in[1][2] <= $random;
  in[2][0] <= $random;
  in[2][1] <= $random;
  in[2][2] <= $random;
  count <= count + 8'b1;
 
  if ( &count ) $stop;
end
 
 
always @(posedge clk) begin
  for (i=0;i<=2;i=i+1) begin
    for (j=0;j<=2;j=j+1) begin
      n <= in[i][j];
      hist[n] <= hist[n]+1'b1;
    end
  end
end
 
endmodule

---

I'm assuming this is non-synthesizable testbench code, because there are blocking statements in the always block. I attempted to synthesize the code to see what those blocking statements would generate but the results didn't make much sense. I used ISE 13.3, probably should have used Quartus II 12 as I've had issues with ISE RTL schematic generation.

Im a beginner in verilog.It was a problem with declaration.I tried your code too.Thanks for the help.