Need some help with _BV() macro

[borge]

Hi

Have been reading up on Pogramming, and starting to understand some basics.
I got a problem when i wanted to add more ports to this easy tutorial.

When i added the _BV(PD5), this was the only led blinking, not both. how do i configure this.
Do i need to define the pins separately ?
I have searched the net, but not any clear answers.
I used Programmers notepad.

#include <avr/interrupt.h>
#define F_CPU 100000UL
#include <util\delay.h>

int main() 
{

DDRD = _BV(PD4);           // this is the original
DDRD = _BV(PD5);           // i added this

while(1) {

PORTD = _BV(PD4);
_delay_ms(1000);

PORTD  &= ~_BV(PD4);
_delay_ms(1000);

PORTD = _BV(PD5);                  // The PD5 i added
_delay_ms(1000);

PORTD &= _BV(PD5);
_delay_ms(1000); 

}
   return (0);
}

 

[alexan_e]

_BV(x) is the equivalent of (1<<x)

When you use

DDRD = _BV(PD4);           // this is the original
DDRD = _BV(PD5);           // i added this

it is the equivalent of

DDRD = 0b00010000;
DDRD = 0b00100000;

So you assign a value and then another value so only the last value stands

In order to preserve the value and set another bit you have to use the OR operator

DDRD = _BV(PD4);
DDRD |= _BV(PD5);      // the equivalent of DDRD =  DDRD | _BV(PD5);

Even better is to do this

DDRD = _BV(PD5) | _BV(PD4);

- - - Updated - - -

You should apply OR in a similar manner when you set the port

PORTD = _BV(PD5);                  // this assigns 0 to all bits except from bit 5

Use this instead

PORTD |= _BV(PD5);                  // keep the current value and in addition set bit5

 

[borge]

Thanks alexan_e.

Will try this evening.

When i use this, and configuring two ports or more, do i continue with the

PORTD [COLOR="#FF0000"]|[/COLOR]= _BV macro  //for each port

And keep the first without th OR Operator
PORTD = _BV(PD4);

PORTD |= _BV(PD5);                  // keep the current value and in addition set bit5

 

[alexan_e]

It depends on what you want to do, if you use an assignment like

PORTD = _BV(PD5);

all bits are set to 0 excerpt from bit5

but if you use

PORTD |= _BV(PD5);

then you set pin5 and any of the other bits previously set keep the value they had

Take a look at https://www.avrfreaks.net/index.php?name=pnphpbb2&file=viewtopic&t=37871

 

[borge]

Thanks alexan_e

your help did the trick. and i read from the link you gave me.

i used both the _BV macro, and 0b1000000; way to test, varied the delay and played around with it.

:smile: