[PIC] help regarding PIC p18f1330

[ruben91]

i am new to pic18f1330, i have written a code to test that the pic18f1330 works fine, but i can't get it work even for simple led on/off coding, please help me regarding this. I have attacted th code together with the connection of my pic. scared it was the wrong part..thank you

#include <p18f1330.h>
#pragma config OSC=INTIO2
#pragma config WDT = OFF
#pragma config DEBUG=ON
void main ()
{
	TRISB=1; // switch
	TRISA=0; // LED
	
	while(1)
	{
		if(PORTBbits.RB1==0)
			PORTHbits.RA0=1;// light on
		else
			PORTAbits.RA0=0;// light off
	}
}

 

[milan.rajik]

Are you using C18 or XC8 COmpiler ? If using XC8 Compiler then include XC.h file. Also include the line

---

Code C - [expand]
1
#define _XTAL_FREQ 4000000

---

Try this code. Disable ADC by configuring ANSELx ot ADCONx registers. Disable Comparator using CMxCOMx or CMCON registers.

---

Code C - [expand]
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
#include <p18f1330.h>
 
#pragma config OSC=INTIO2
#pragma config WDT = OFF
#pragma config DEBUG = ON
 
void main ()
{
    TRISB=1; // switch
    TRISA=0; // LED
    
    while(1)
    {
        if(LATBbits.LATB1 == 0)
        //Add 30 ms delay here
        while(LATBbits.LATB1 == 0)
            LATAbits.LATA0 = 1;// light on
        else
            LATAbits.LATA0 = 0;// light off
    }
}

---

- - - Updated - - -

Are you using C18 or XC8 COmpiler ? If using XC8 Compiler then include XC.h file. Also include the line

---

Code C - [expand]
1
#define _XTAL_FREQ 4000000

---

Try this code. Disable ADC by configuring ANSELx ot ADCONx registers. Disable Comparator using CMxCOMx or CMCON registers.

---

Code C - [expand]
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
#include <p18f1330.h>
 
#pragma config OSC=INTIO2
#pragma config WDT = OFF
#pragma config DEBUG = ON
 
void main ()
{
    TRISB=1; // switch
    TRISA=0; // LED
    
    while(1)
    {
        if(LATBbits.LATB1 == 0)
        //Add 30 ms delay here
        while(LATBbits.LATB1 == 0)
            LATAbits.LATA0 = 1;// light on
        else
            LATAbits.LATA0 = 0;// light off
    }
}

---

 

[ruben91]

Are you using C18 or XC8 COmpiler ? If using XC8 Compiler then include XC.h file. Also include the line

---

Code C - [expand]
1
#define _XTAL_FREQ 4000000

---

Try this code. Disable ADC by configuring ANSELx ot ADCONx registers. Disable Comparator using CMxCOMx or CMCON registers.

---

Code C - [expand]
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
#include <p18f1330.h>
 
#pragma config OSC=INTIO2
#pragma config WDT = OFF
#pragma config DEBUG = ON
 
void main ()
{
    TRISB=1; // switch
    TRISA=0; // LED
    
    while(1)
    {
        if(LATBbits.LATB1 == 0)
        //Add 30 ms delay here
        while(LATBbits.LATB1 == 0)
            LATAbits.LATA0 = 1;// light on
        else
            LATAbits.LATA0 = 0;// light off
    }
}

---

- - - Updated - - -

Are you using C18 or XC8 COmpiler ? If using XC8 Compiler then include XC.h file. Also include the line

---

Code C - [expand]
1
#define _XTAL_FREQ 4000000

---

Try this code. Disable ADC by configuring ANSELx ot ADCONx registers. Disable Comparator using CMxCOMx or CMCON registers.

---

Code C - [expand]
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
#include <p18f1330.h>
 
#pragma config OSC=INTIO2
#pragma config WDT = OFF
#pragma config DEBUG = ON
 
void main ()
{
    TRISB=1; // switch
    TRISA=0; // LED
    
    while(1)
    {
        if(LATBbits.LATB1 == 0)
        //Add 30 ms delay here
        while(LATBbits.LATB1 == 0)
            LATAbits.LATA0 = 1;// light on
        else
            LATAbits.LATA0 = 0;// light off
    }
}

---

thank you sir, i wil try it. i'm using mplab ide wit c18 compiler and pickit2. is my conection for circuit is correct?

- - - Updated - - -

its still not fuctioning sir..

- - - Updated - - -

is my circuit diagram is correct??

 

[milan.rajik]

In the config settings set DEBUG = OFF

Here I am attaching mikroC PRO PIC code. Test it in hardware and reply. LED toggles on button press and release.

 

[Aussie Susan]

Better still, never mention the DEBUG config setting in your code. It is just about the only config setting that you should never play with yourself.
The reason is that this setting is controlled by the MPLAB(x) IDE depending on whether you build for 'debug' or 'release'.
While your code might seem to work (in that the LED will turn on and off when you push the button. However you really should look at including debouncing code (or hardware) on the push button input; if you try to use your current technique in a situation where receiving multiple 'switches' can impact on the item you are controlling (i.e. 1 push to increment a temperature by 1 degree - without debouncing you will step up the temperature by any number of degrees for each "push" and similarly on release).
Susan

 

[ruben91]

In the config settings set DEBUG = OFF

Here I am attaching mikroC PRO PIC code. Test it in hardware and reply. LED toggles on button press and release.

Thank you sir.. its working fine now... thanks alot!!
MY PROBLEM WAS THE DEBUG config and also the connection of my push button..